Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom LinkedHashSet subclass for match analysis #10361

Merged
merged 1 commit into from Apr 20, 2023
Merged

Custom LinkedHashSet subclass for match analysis #10361

merged 1 commit into from Apr 20, 2023

Conversation

lrytz
Copy link
Member

@lrytz lrytz commented Apr 4, 2023

Workaround for scala/bug#12760

@scala-jenkins scala-jenkins added this to the 2.13.12 milestone Apr 4, 2023
@lrytz
Copy link
Member Author

lrytz commented Apr 4, 2023

@KisaragiEffective is it possible for you to try version 2.13.11-bin-c1a11b1-SNAPSHOT? In sbt it would be

resolvers += "pr" at "https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/"
scalaVersion := "2.13.11-bin-c1a11b1-SNAPSHOT"

@SethTisue SethTisue modified the milestones: 2.13.12, 2.13.11 Apr 4, 2023
@lrytz
Copy link
Member Author

lrytz commented Apr 12, 2023

or maybe @michelou?

@michelou
Copy link

michelou commented Apr 12, 2023 •
edited

or maybe @michelou?

@lrytz I guess you are referring to #10258 (blocking Scala dependency in the Flix project). I'll have a try and will report any improvement.

@lrytz
Copy link
Member Author

lrytz commented Apr 12, 2023

Yes, thanks @michelou.

@KisaragiEffective
Copy link
Contributor

KisaragiEffective commented Apr 13, 2023 •
edited

@KisaragiEffective is it possible for you to try version 2.13.11-bin-c1a11b1-SNAPSHOT? In sbt it would be

resolvers += "pr" at "https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots/"
scalaVersion := "2.13.11-bin-c1a11b1-SNAPSHOT"

@lrytz sorry for delayed reply 😓 I've just verified that your approach works in our organization project 🚀 (PR)

@SethTisue SethTisue added backport candidate prio:hi high priority (used only by core team, only near release time) and removed backport candidate labels Apr 14, 2023
@SethTisue
Copy link
Member

SethTisue commented Apr 14, 2023 •
edited

@michelou (we're still also interested in results of testing in the Flix context, of course)

@michelou michelou mentioned this pull request Apr 15, 2023
Merged
@michelou
Copy link

@SethTisue @lrytz I confirm that the workaround does solve the performance issue observed when building Flix with the Scala option -Ypatmat-exhaust-depth. See my comment in flix/flix#4896 for further details.

@som-snytt
Copy link
Contributor

@michelou now your follow-up PR can be titled, pleasure: update Scala 2 version.

@KisaragiEffective
Copy link
Contributor

nitpick: L117 to L119 should be reflect scala/bug#12760.

@lrytz lrytz marked this pull request as ready for review April 17, 2023 08:10
@lrytz lrytz merged commit 28eef15 into scala:2.13.x Apr 20, 2023
3 checks passed
@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label Apr 20, 2023
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed prio:hi high priority (used only by core team, only near release time) release-notes worth highlighting in next release notes labels May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library:collections PRs involving changes to the standard collection library
Projects
None yet
Milestone
2.13.11
6 participants
@lrytz @michelou @KisaragiEffective @SethTisue @som-snytt @scala-jenkins