New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add JDK 21 Early Access to nightly CI #10394
Conversation
I had hoped that this would be as easy adding |
okay, I got the CI config correct I think but the new jobs are now failing because of scala/bug#12783 (which is the root cause of sbt/sbt#7235) and note that it fails trying to even start sbt so, eventually we do want to merge this PR, but we won't able to use this PR's setup to test the fix for 12783, because of the circularity involved we'll need to make the fix, locally publish a Scala with the fix (2.12.18-M2, say), then test that it fixes sbt/sbt#7235 by starting sbt with that Scala version (will we need to build a new sbt, or can we tell the launcher directly to use 2.12.18-M2?). if that succeeds, then we're good @eed3si9n if I have 2.12.18-M2 published locally, can I tell sbt to use it without having to rebuild sbt? |
You could try something like launch sbt -Dsbt.scala.version=2.12.18-M2 with potentially needing // Global / resolvers += "scala-integration" at "https://scala-ci.typesafe.com/artifactory/scala-integration/"
def scala212 = "2.12.18-M2"
scalaVersion := scala212
dependencyOverrides += "org.scala-lang" % "scala-library" % scala212
dependencyOverrides += "org.scala-lang" % "scala-compiler" % scala212 |
after #10397 goes through, this one can come next |
in my local testing on top of #10397, I'm seeing some test failures:
a number of tests are sensitive to a -res17: () => Int = <function>
+res17: () => Int = $Lambda/0x000000080177c430@52449bdb the failing neg tests are because of test sensitivity to exact stack trace contents: - at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
+ at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) and |
Probably needs an adjustment here: scala/src/partest/scala/tools/partest/ReplTest.scala Lines 78 to 79 in 418f76d
|
optional bit after OK also make that last group noncapturing.
|
@SethTisue thanks for early action on EA. I pushed a tweak. I feel so nerdy pushing to 2.12. |
rebased as #10400 |
prompted by scala/bug#12783