Re-enable new ambiguity warning under 2.13 #10462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include a quick fix.
som-snytt
reviewed
Jul 15, 2023
| val cat = if (currentRun.isScala3) WarningCategory.Scala3Migration else WarningCategory.Other | ||
| val fix = List(CodeAction("ambiguous reference", Some(w.msg), List(TextEdit(tree.pos.focusStart, w.fix)))) | ||
| runReporting.warning(tree.pos, w.msg, cat, context.owner, fix) | ||
| }) |
There was a problem hiding this comment.
Maybe the way to motivate something.foreach { w => block } syntax is to say, the lambda is a block, much like "anonymous pattern-matching function" is a block (of cases). For this syntax, it introduces a parameter. How slick! Or maybe, "it's like { case w => block } but you can omit the case. Hey!
SethTisue
added
prio:hi
SethTisue
approved these changes
Jul 22, 2023
SethTisue
removed
the
prio:hi
|
@lrytz we don't need to release-note this... or do we? |
|
I was hoping to read an explanation. Oh, is this to warn without |
|
The new warning has a very detailed message, so it probably doesn't need to be mentioned in the release notes. |
3 tasks
ijuma
added a commit
to apache/kafka
that referenced
this pull request
Sep 24, 2023
It offers a quickfix action for certain errors, includes a number of bug fixes and it introduces a new warning by default (scala/scala#10462). In addition to the scala version bump, we also fix the new compiler warnings and bump the scalafmt version (the previous version failed with the new scala version). Release notes: https://github.com/scala/scala/releases/tag/v2.13.12 Reviewers: Divij Vaidya <diviv@amazon.com>, Satish Duggana <satishd@apache.org>
rreddy-22
pushed a commit
to rreddy-22/kafka-rreddy
that referenced
this pull request
Oct 3, 2023
It offers a quickfix action for certain errors, includes a number of bug fixes and it introduces a new warning by default (scala/scala#10462). In addition to the scala version bump, we also fix the new compiler warnings and bump the scalafmt version (the previous version failed with the new scala version). Release notes: https://github.com/scala/scala/releases/tag/v2.13.12 Reviewers: Divij Vaidya <diviv@amazon.com>, Satish Duggana <satishd@apache.org>
k-wall
pushed a commit
to k-wall/kafka
that referenced
this pull request
Nov 21, 2023
It offers a quickfix action for certain errors, includes a number of bug fixes and it introduces a new warning by default (scala/scala#10462). In addition to the scala version bump, we also fix the new compiler warnings and bump the scalafmt version (the previous version failed with the new scala version). Release notes: https://github.com/scala/scala/releases/tag/v2.13.12 Reviewers: Divij Vaidya <diviv@amazon.com>, Satish Duggana <satishd@apache.org>
AnatolyPopov
pushed a commit
to aiven/kafka
that referenced
this pull request
Feb 16, 2024
It offers a quickfix action for certain errors, includes a number of bug fixes and it introduces a new warning by default (scala/scala#10462). In addition to the scala version bump, we also fix the new compiler warnings and bump the scalafmt version (the previous version failed with the new scala version). Release notes: https://github.com/scala/scala/releases/tag/v2.13.12 Reviewers: Divij Vaidya <diviv@amazon.com>, Satish Duggana <satishd@apache.org>
Cerchie
pushed a commit
to Cerchie/kafka
that referenced
this pull request
Feb 22, 2024
It offers a quickfix action for certain errors, includes a number of bug fixes and it introduces a new warning by default (scala/scala#10462). In addition to the scala version bump, we also fix the new compiler warnings and bump the scalafmt version (the previous version failed with the new scala version). Release notes: https://github.com/scala/scala/releases/tag/v2.13.12 Reviewers: Divij Vaidya <diviv@amazon.com>, Satish Duggana <satishd@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a quick fix.
follow-up for #10339