Remove by-name restriction for case copy #10770
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/7879-case-copy-by-name
branch
from
6b329bf
to
7b8b267
Compare
I think we have to as it's changing the binary output. |
som-snytt
force-pushed
the
issue/7879-case-copy-by-name
branch
from
7b8b267
to
914c657
Compare
lrytz
reviewed
May 13, 2024
| val classParamss = constrParamss(cdef) | ||
| def warn() = runReporting.warning(cdef.namePos, "case `copy` method is allowed to have by-name parameters under Scala 3 (or with -Xsource-features:case-copy-by-name)", Scala3Migration, cdef.symbol) | ||
| def isDisallowed(vd: ValDef) = isRepeatedParamType(vd.tpt) || isByNameParamType(vd.tpt).tap(if (_) warn()) | ||
| def copyOK = currentRun.sourceFeatures.caseCopyByName || !mexists(classParamss)(isDisallowed) |
There was a problem hiding this comment.
now it tries to generate copy for repeated params:
➜ sandbox scpr 10770 T.scala -Vprint:cleanup -Xsource:3-cross
> scala compile --server=false -S 2.13.15-bin-914c657-SNAPSHOT -d . -release 8 --repository https://scala-ci.typesafe.com/artifactory/scala-pr-validation-snapshots T.scala -Vprint:cleanup -Xsource:3-cross
/Users/luc/code/scala/scala13/sandbox/T.scala:1: error: type mismatch;
found : Seq[Int]
required: Int
case class C(x: Int)(y: Int*)
^
1 error
There was a problem hiding this comment.
thanks, oops, I'll rename it to sourceFeatures.anythingGoes.
som-snytt
force-pushed
the
issue/7879-case-copy-by-name
branch
from
914c657
to
4e5ceaa
Compare
som-snytt
force-pushed
the
issue/7879-case-copy-by-name
branch
from
4e5ceaa
to
9e19996
Compare
|
Refactored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Xsource-features:case-copy-by-namesynthesizes case copy method when a parameter is by-name.Fixes scala/bug#7879