Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys.env now throws on null environment variable #8579

Merged
merged 1 commit into from Dec 9, 2019
Merged

sys.env now throws on null environment variable #8579

merged 1 commit into from Dec 9, 2019

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented Dec 7, 2019 •
edited

Resubmit #8508

Fixes scala/bug#9957

@scala-jenkins scala-jenkins added this to the 2.13.2 milestone Dec 7, 2019
@som-snytt som-snytt mentioned this pull request Dec 7, 2019
Closed
diesalbla
diesalbla approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@diesalbla diesalbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of programs failing as soon as something is definitely foul. So 👍
However, we may need to highlight this on the release notes, since it may break many a deploy.

@diesalbla diesalbla added the library:base Changes to the base library, i.e. Function Tuples Try label Dec 7, 2019
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Dec 8, 2019
@som-snytt @lrytz
sys.env lookup falls back on System.getenv(_)
e7aa7c7 
The latter is case-insensitive on certain platforms
@lrytz lrytz merged commit 82b3888 into scala:2.13.x Dec 9, 2019
@som-snytt som-snytt deleted the issue/9957 branch December 9, 2019 15:06
@SethTisue SethTisue changed the title Throw on null env var sys.env now throws on null environment variable Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

@diesalbla diesalbla diesalbla approved these changes

Assignees
No one assigned
Labels
library:base Changes to the base library, i.e. Function Tuples Try release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.2
5 participants
@som-snytt @lrytz @diesalbla @SethTisue @scala-jenkins