Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no more -Xsource:2.14, only -Xsource:3 #8812

Merged
merged 1 commit into from Mar 27, 2020

Conversation

dwijnand
Copy link
Member

Back when it was introduced, Scala 2.14 was in the plan. But now the plan is to not have a 2.14 as a transition to 3.0 but to transition straight from 2.13. So this repoints 2.14 to 3.

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Mar 18, 2020
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a warning when someone says -Xsource:2.14? Because after this PR, that setting no longer has an effect.

@dwijnand
Copy link
Member Author

Should we also add a warning when someone says -Xsource:2.14? Because after this PR, that setting no longer has an effect.

Eugene's making that argument in #8812 (comment)

@som-snytt
Copy link
Contributor

I have a commit to remove 2.12; and we can also eliminate 2.13, which has more usages, because isScala213 is now always true. (There are more usages of 213.)

I think an arbitrary future version is acceptable, e.g., -Xsource:3.2 to pick up anything they might be trying out. There are so many dotty features they routinely push out, "maybe after 3.0, 3.2".

Similarly for anyone using 2.14.

@dwijnand
Copy link
Member Author

I don't mind rebasing my PR if yours lands first. Also, if you'd like, I could rebase yours if this lands first. But I think it's best to keep them separate so neither impedes the other from landing. (Though I'm happy to be convinced to combine them.)

@lrytz lrytz modified the milestones: 2.13.3, 2.13.2 Mar 27, 2020
@lrytz lrytz merged commit bb894b2 into scala:2.13.x Mar 27, 2020
@dwijnand dwijnand deleted the Xsource-3 branch March 27, 2020 09:30
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Mar 27, 2020
@SethTisue SethTisue changed the title Kill 2.14, long live -Xsource:3 There is no more -Xsource:2.14, only -Xsource:3 Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
7 participants