New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There is no more -Xsource:2.14, only -Xsource:3 #8812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a warning when someone says -Xsource:2.14
? Because after this PR, that setting no longer has an effect.
Eugene's making that argument in #8812 (comment) |
f0ba0d1
to
3503b46
Compare
I have a commit to remove 2.12; and we can also eliminate 2.13, which has more usages, because I think an arbitrary future version is acceptable, e.g., Similarly for anyone using 2.14. |
I don't mind rebasing my PR if yours lands first. Also, if you'd like, I could rebase yours if this lands first. But I think it's best to keep them separate so neither impedes the other from landing. (Though I'm happy to be convinced to combine them.) |
Back when it was introduced, Scala 2.14 was in the plan. But now the plan is to not have a 2.14 as a transition to 3.0 but to transition straight from 2.13. So this repoints 2.14 to 3.