Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow \" in single-double-quoted string interpolations #8830

Merged
merged 2 commits into from Mar 31, 2021
Merged

Allow \" in single-double-quoted string interpolations #8830

merged 2 commits into from Mar 31, 2021
+131 −26

Commits on Mar 17, 2021

  1. Allow \" in single-quoted string interpolations 

    Changing `"Hello, \"World\""` to `s"Hello, \"$who\""` no longer breaks.

Before this change, `\"` terminated single-quoted interpolated string
literals, now the string remains open. The scanner doesn't interpret
the escape sequence, string interpolators can do so (`s` and `f` do).

Breaking changes:
  - `raw"c:\"` no longer compiles, it's now an unclosed string
  - `raw"c:\" // uh"` used to evaluate to `"""c:\"""`, now it's
    `"""c:\" // uh"""`
    @eed3si9n @lrytz
    eed3si9n authored and lrytz committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    0947ccd View commit details
    Browse the repository at this point in the history

  2. Spec for \" in interpolated strings 

    Also, unicode escapes are no longer interpreted in interpolated strings.
Interpolators can still interpret them, but that's not in the spec.
    @lrytz
    lrytz committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    62f515d View commit details
    Browse the repository at this point in the history