Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbol#toString is now Symbol(foo) instead of the deprecated single-quote form 'foo #8933

Merged
merged 1 commit into from Apr 29, 2020
Merged

Symbol#toString is now Symbol(foo) instead of the deprecated single-quote form 'foo #8933

merged 1 commit into from Apr 29, 2020

Conversation

changvvb
Copy link
Contributor

@changvvb changvvb commented Apr 28, 2020 •
edited by SethTisue

Before:

scala 2.13.2> Symbol("foo")
val res0: Symbol = 'foo

After:

scala 2.13.3> Symbol("foo")
val res0: Symbol = Symbol(foo)

Fixes scala/bug#11943

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Apr 28, 2020
@dwijnand
Copy link
Member

Thanks!

som-snytt
som-snytt requested changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@som-snytt som-snytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, definitely requires squashing.

test/junit/scala/lang/stringinterpol/StringContextTest.scala Show resolved Hide resolved
@som-snytt som-snytt merged commit edf2952 into scala:2.13.x Apr 29, 2020
@changvvb changvvb deleted the update-symbol-toString branch April 29, 2020 09:26
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Apr 30, 2020
@SethTisue SethTisue changed the title Update Symbol.toString Change Symbol.toString to output Symbol(foo) instead of the deprecated single-quote form May 8, 2020
@SethTisue SethTisue changed the title Change Symbol.toString to output Symbol(foo) instead of the deprecated single-quote form Change Symbol.toString to output Symbol(foo) instead of the deprecated single-quote form 'foo May 8, 2020
@SethTisue
Copy link
Member

a few projects in the community build were (inappropriately) relying on the old behavior:

@SethTisue SethTisue mentioned this pull request May 8, 2020
Merged
@SethTisue SethTisue added the library:base Changes to the base library, i.e. Function Tuples Try label Jun 23, 2020
@SethTisue SethTisue changed the title Change Symbol.toString to output Symbol(foo) instead of the deprecated single-quote form 'foo Symbol#toString is now Symbol(foo) instead of the deprecated single-quote form 'foo Jun 23, 2020
@SethTisue SethTisue changed the title Symbol#toString is now Symbol(foo) instead of the deprecated single-quote form 'foo Symbol#toString is now Symbol(foo) instead of the deprecated single-quote form 'foo Jun 23, 2020
@SethTisue SethTisue mentioned this pull request Jul 26, 2020
Merged
@som-snytt
Copy link
Contributor

a few projects in the community build were (inappropriately) relying on the old behavior:

Surprisingly, this change diverges from the spec, which the community were appropriately relying on. See 1.3.7! which is obsolete on a couple of points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwijnand dwijnand dwijnand approved these changes

@som-snytt som-snytt som-snytt approved these changes

Assignees
No one assigned
Labels
library:base Changes to the base library, i.e. Function Tuples Try release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.3
5 participants
@changvvb @dwijnand @SethTisue @som-snytt @scala-jenkins