Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect @uncheckedVariance in higher-kinded types (fixing 2.13.2 regression) #8938

Merged
merged 1 commit into from May 4, 2020

Conversation

joroKr21
Copy link
Member

A modification of varianceInType was necessary to propagate a
boolean flag that controls the behaviour wrt @uncheckedVaraince.

Fixes scala/bug#11968

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Apr 29, 2020
@SethTisue SethTisue added the prio:blocker release blocker (used only by core team, only near release time) label Apr 30, 2020
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me. But probably good for someone else to give the nod.

src/reflect/scala/reflect/internal/Variances.scala Outdated Show resolved Hide resolved
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

A modification of `varianceInType` was necessary to propagate a
boolean flag that controls the behaviour wrt `@uncheckedVaraince`.
@joroKr21 joroKr21 force-pushed the unchecked-variance-in-hkt branch from abef354 to bacd612 Compare May 4, 2020 09:01
@lrytz lrytz merged commit 2adbc1a into scala:2.13.x May 4, 2020
@joroKr21 joroKr21 deleted the unchecked-variance-in-hkt branch May 4, 2020 15:40
@SethTisue SethTisue removed the prio:blocker release blocker (used only by core team, only near release time) label May 4, 2020
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label May 12, 2020
@SethTisue SethTisue changed the title Respect uncheckedVariance in higher-kinded types Respect uncheckedVariance in higher-kinded types (fixing 2.13.2 regression) Jun 23, 2020
@SethTisue SethTisue changed the title Respect uncheckedVariance in higher-kinded types (fixing 2.13.2 regression) Respect @uncheckedVariance in higher-kinded types (fixing 2.13.2 regression) Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes worth highlighting in next release notes
Projects
None yet
5 participants