Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow trailing backslash in string interpolators #8942

Merged
merged 1 commit into from May 6, 2020
Merged

Allow trailing backslash in string interpolators #8942

merged 1 commit into from May 6, 2020

Conversation

martijnhoekstra
Copy link
Contributor

@scala-jenkins scala-jenkins added this to the 2.13.3 milestone Apr 30, 2020
martijnhoekstra
martijnhoekstra commented Apr 30, 2020
View reviewed changes
test/files/run/literals.scala Outdated
Comment on lines 31 to 32
check_success("""s"\u0024" == "$"""", s"\u0024", "$")
check_success("s\"\"\"\\u0024\"\"\" == \"$\"", s"""\u0024""", "$")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while coming through, do the actual naming

@SethTisue SethTisue added the prio:blocker release blocker (used only by core team, only near release time) label Apr 30, 2020
@lrytz
Copy link
Member

lrytz commented May 6, 2020

Thanks, @martijnhoekstra

@lrytz lrytz merged commit c9a8b6c into scala:2.13.x May 6, 2020
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed prio:blocker release blocker (used only by core team, only near release time) labels May 6, 2020
@SethTisue SethTisue changed the title append trailing / when processing unicode escapes Append trailing / when processing unicode escapes Jun 23, 2020
@SethTisue SethTisue changed the title Append trailing / when processing unicode escapes Append trailing / when processing unicode escapes Jun 23, 2020
@avdv
Copy link
Contributor

avdv commented Jun 26, 2020

First thought: why on earth would I want to append a trailing / while processing unicode escapes ? You meant to append a \, right? 🤓

@SethTisue SethTisue changed the title Append trailing / when processing unicode escapes Allow trailing backslash when processing unicode escapes Jun 26, 2020
@SethTisue SethTisue changed the title Allow trailing backslash when processing unicode escapes Allow trailing backslash in string interpolators Jun 26, 2020
@SethTisue
Copy link
Member

@avdv I've updated the 2.13.3 release notes as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.3
5 participants
@martijnhoekstra @lrytz @avdv @SethTisue @scala-jenkins