Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage multi-argument infix syntax: lint applications (x op (a, b)), also lint operator-name definitions #8951

Merged
merged 6 commits into from May 6, 2020
Merged

Discourage multi-argument infix syntax: lint applications (x op (a, b)), also lint operator-name definitions #8951

merged 6 commits into from May 6, 2020

Commits on May 4, 2020

  1. Lint multiarg infix operand 

    Lint multiarg infix applications `x op (a, b, c)`
and also method definitions with multiple parameters
where the method name is either an operator identifier
or a plain identifier ending in an operator character.
    @som-snytt
    som-snytt committed May 4, 2020
    Configuration menu
    Copy the full SHA
    6cf73d0 View commit details
    Browse the repository at this point in the history

  2. Reduce multiarg infix applications

    @som-snytt
    som-snytt committed May 4, 2020
    Configuration menu
    Copy the full SHA
    cd6d4a1 View commit details
    Browse the repository at this point in the history

  3. Don't warn about implicit multiargs 

    For example, `def ?[A: T: U]` may be intended
to be invoked `r ?` and not `r ? (t, u)`.
    @som-snytt
    som-snytt committed May 4, 2020
    Configuration menu
    Copy the full SHA
    25bbbf4 View commit details
    Browse the repository at this point in the history

  4. Infix ops are not local defs 

    Move the check to typer for owner test.
    @som-snytt
    som-snytt committed May 4, 2020
    Configuration menu
    Copy the full SHA
    54f5e75 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2020

  1. Don't warn multiarg infix if deprecated or unused

    @som-snytt
    som-snytt committed May 5, 2020
    Configuration menu
    Copy the full SHA
    559f892 View commit details
    Browse the repository at this point in the history

  2. Avoid multiarg infix warning on Subtractable 

    The cost is only incurred when warning.
    @som-snytt
    som-snytt committed May 5, 2020
    Configuration menu
    Copy the full SHA
    841b880 View commit details
    Browse the repository at this point in the history