Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make -Wunused:imports work again even when -Ymacro-annotations is enabled #8962

Merged
merged 1 commit into from May 6, 2020
Merged

Make -Wunused:imports work again even when -Ymacro-annotations is enabled #8962

merged 1 commit into from May 6, 2020

Conversation

som-snytt
Copy link
Contributor

@som-snytt som-snytt commented May 6, 2020 •
edited by SethTisue

MacroAnnotationNamers uses makeImportContext

This entry point is required for bookkeeping used imports.

Fixes scala/bug#11978

@som-snytt
MacroAnnotationNames uses makeImportContext
532ca2d 
This entry point is required for bookkeeping used imports.
@scala-jenkins scala-jenkins added this to the 2.13.3 milestone May 6, 2020
@som-snytt som-snytt requested a review from lrytz May 6, 2020 00:53
@som-snytt som-snytt changed the title MacroAnnotationNames uses makeImportContext MacroAnnotationNamers uses makeImportContext May 6, 2020
@som-snytt
Copy link
Contributor Author

It's different enough from Namers that it should have additional tests, expanding while exercising imports within and above the expanded trees.

@SethTisue SethTisue added the prio:blocker release blocker (used only by core team, only near release time) label May 6, 2020
lrytz
lrytz approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty

@lrytz lrytz merged commit 483470c into scala:2.13.x May 6, 2020
@SethTisue SethTisue added release-notes worth highlighting in next release notes and removed prio:blocker release blocker (used only by core team, only near release time) labels May 7, 2020
@SethTisue SethTisue changed the title MacroAnnotationNamers uses makeImportContext Make -Wunused:imports work again even when -Ymacro-annotations is enabled May 7, 2020
@som-snytt som-snytt deleted the issue/11978 branch May 8, 2020 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.3
4 participants
@som-snytt @lrytz @SethTisue @scala-jenkins