New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not lint multiarg for mixed op def #9026
Conversation
context is #8951 (comment) |
couldn't |
Actually, Seth, after I boned up (so to speak) on NameTransformer, I was too tired to overthink it. The comment was that the IDE used it. A name can be arbitrarily junk. Like boldface.
|
c5bda72
to
8b2fb1e
Compare
As usual, I wound up taking Seth's advice. Since we only care about legal idents, the lint only checks for leading op char. Oh wait, there's still the question of backticks. Oh wait, I'm too tired. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and this still seems right to me even if backticks enter the picture. But perhaps one more reviewer would like to ponder all of this at least a little before we hit "merge".
Here's a counter example: There's a whitespace between scala/src/reflect/scala/reflect/internal/Printers.scala Lines 597 to 598 in 8aefe5e
|
Follow-up per review by @SethTisue
Remove lint of definition of
lines_!
, which is arguably innocent.