Fix 2.13-only bug in Java collection converters that caused some operations to perform an extra pass #9058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
changed the title
|
If we can get this reviewed & merged within the next 1-2 days great, otherwise let's push it to 2.13.4. |
|
@retronym gave me an informal OK, so maybe he can do the formal one too :-) |
|
We use these adapters quite a bit in Apache Kafka, so it would be nice to get the fix. We have recently switched to Scala 2.13 as the default Scala version. |
retronym
approved these changes
Jun 23, 2020
SethTisue
added
the
library:collections
SethTisue
changed the title
SethTisue
changed the title
SethTisue
changed the title
SethTisue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11976
Quite a bunch of MiMa exceptions here...