Add the Tasty Reader [ci: last-only] #9109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyProduct with Box
This commit is a squash of several commits to atomically add the feature: When indexing a scope for the first time to set up completers, add lazy annotations to symbols. At the end of the indexing, force the annotations and if one is scala.annotation.internal.Child[T], add the symbol of T as a sealed child. If we are not indexing statements, such as completing the a method and reading its parameters, force annotations as soon as each symbol is initialised, this is ok because the owner tree for the definition is also initialised so forward references can be safely accessed. force sealed children after indexing scope cache RepeatedAnnot force all annotations early, catching more errors Also force annotations for lookahead contexts. It would be good to see if perhaps we can share a single annotation cache per tasty file and force from one place. Force annotations for each new symbol Additionally, when sequencing statements, only force after the whole sequence is indexed. Forceable annotations are now stored in and forced from the initial context. Made it more lazy to print parents of a class. If a LambdaPolyType is in a New tree, unwrap it. force annotations at end of createMemberSymbol only make lazy annotation if we delay its evaluation
… class info. Before this, inherited members may not be visible at the point of forcing the annotation on a definition in the template. Also moved symbol cache to the initial context so that child contexts all pass to the same cache.
Inner classes can not be found with Mirror getRequiredClass, so we should have another way to compare types to signatures, this proposes to instead convert method signatures to Signature[ErasedTypeRef]
Read inner classes in signatures, force annotations after template parents
Fix JavaUniverseForce
lrytz
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #8865 for original guide to reviewing (which has been copied to relevant doc comments in the code)