Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exhaustivity uncheckableType's logic for tuples #9163

Merged
merged 1 commit into from Sep 7, 2020

Commits on Aug 11, 2020

  1. Fix exhaustivity uncheckableType's logic for tuples

    As tuples (e.g. Tuple2) are case classes, for which `enumerateSubtypes`
    returns `List(List(tp))` therefore making it "checkable", any tuple type
    was accidentally always passing (or at least it has since that `isCase`
    branch was added to `enumerateSubtypes`).  This was leading to false
    positives in the exhaustivity checking, as a tuple of non-sealed types
    was being deemed inexhaustive with a wildcard `(_, _)` counter-example.
    dwijnand committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    e5bda18 View commit details
    Browse the repository at this point in the history