Exhaustivity: don't widen & then warn on singleton types #9209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An ambitious attempt at "just" shuffling some widen's around... but it didn't seem to produce unwanted effects after a quick |
dwijnand
force-pushed
the
exhaust-literal-type-false-positive
branch
from
ac63c93
to
13e3b96
Compare
lrytz
reviewed
Sep 21, 2020
src/compiler/scala/tools/nsc/transform/patmat/MatchOptimization.scala
Outdated
Show resolved
Hide resolved
dwijnand
force-pushed
the
exhaust-literal-type-false-positive
branch
2 times, most recently
from
1c93b0e
to
2fe421a
Compare
lrytz
reviewed
Sep 23, 2020
| val Match(Typed(selTree: Ident, _), cases) = sw | ||
| val sel = selTree.symbol | ||
| val Match(Typed(selTree, _), cases) = sw | ||
| val selArg = selTree match { |
There was a problem hiding this comment.
I'm not sure if this should be a def to avoid structural sharing in the AST. Since trees have mutable fields (.tpe, .pos) this might be a problem - I'm really not sure if it matters in practice. @retronym what's your intuition?
There was a problem hiding this comment.
Oh! Wow, yeah, good catch, thanks. Let's do that.
dwijnand
force-pushed
the
exhaust-literal-type-false-positive
branch
from
2fe421a
to
e2a36e7
Compare
dwijnand
force-pushed
the
exhaust-literal-type-false-positive
branch
from
e2a36e7
to
1becce1
Compare
lrytz
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scala/bug#11603