Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate useful StringOps methods, despite Unicode concerns #9246

Merged

Conversation

bjornregnell
Copy link
Contributor

@bjornregnell bjornregnell commented Oct 13, 2020

Namely: diff, intersect, distinct, distinctBy, sorted, sortWith, sortBy, groupBy, sliding, combinations, permutations`

referring to discussion in issue scala/bug#11676 and on gitter https://gitter.im/scala/contributors?at=5f84ccb4e6840119ec83d0dd

@scala-jenkins scala-jenkins added this to the 2.13.4 milestone Oct 13, 2020
@bjornregnell bjornregnell changed the title fix #11676 un-deprecate useful StringOps operations fixes scala/bug #11676 un-deprecate useful StringOps operations Oct 13, 2020
@julienrf
Copy link
Contributor

For reference, these operations were deprecated here: #6702. The corresponding issue was scala/bug#10881, which related to #6565 (comment)

@SethTisue SethTisue added the library:collections PRs involving changes to the standard collection library label Oct 13, 2020
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of approval:
image

@dwijnand dwijnand merged commit 698fa73 into scala:2.13.x Oct 22, 2020
@dwijnand dwijnand changed the title fixes scala/bug #11676 un-deprecate useful StringOps operations Un-deprecate useful StringOps operations Nov 12, 2020
@SethTisue SethTisue changed the title Un-deprecate useful StringOps operations Un-deprecate useful StringOps methods Nov 17, 2020
@SethTisue SethTisue changed the title Un-deprecate useful StringOps methods Un-deprecate useful StringOps methods, despite Unicode concerns Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library:collections PRs involving changes to the standard collection library
Projects
None yet
5 participants