New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a new prefixDirect in checkKindBounds0 #9404
Conversation
70169c0
to
8a81b55
Compare
/rebuild |
Analogous to `typeSymbolDirect`, we add `prefixDirect`, because `prefix` normalizes type aliases. But kind-checking should not normalize type aliases. This was the intention as noted by comments and `typeSymbolDirect`.
8a81b55
to
219c57e
Compare
/rebuild |
This change seems quite logical to me, but just in case, I'd like to do a community build run: https://scala-ci.typesafe.com/job/scala-2.13.x-jdk11-integrate-community-build/2319/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean. LGTM.
Looks like the two projects that failed in the community build don't work on java 11:
|
What are the parameters for scala 2 changes? "Someone who was unhappy is now happy. No one who was happy is now unhappy." Is it possible to justify any migration pain on Scala 2? |
I guess "fixed in dotty" is always a good thing to strive for |
I assume your question is general, not to be taken as you not being in favour of this or such changes. Re-fixing issues fixed in Scala 3 ("backporting") as well as fast-tracking other changes present in 3, provided they're not too disruptive, are acceptable. |
@joroKr21 I'm looking through all of the 2.13.5 merged PRs and trying to decide which ones should be explicitly mentioned in the 2.13.5 release notes. in your opinion, do any of your PRs (such as this one) merit calling out individually? and/or, it's possible is to give them a collective bullet: |
As far as I can remember most of my fixes for 2.13.5 targeted higher-kinded types but I will go through my merged PRs tomorrow. I'm confident they can be summarised in one entry though. |
@SethTisue something like this: "Assorted fixes to typechecking higher-kinded types (that bring the status quo closer to Scala 3): |
I'll use that, thanks! |
Analogous to
typeSymbolDirect
, we addprefixDirect
, becauseprefix
normalizes type aliases. But kind-checking should not normalize type aliases. This was the intention as noted by comments andtypeSymbolDirect
.Fixes scala/bug#9337
Closes scala/bug#10186, closes scala/bug#9625 with regression tests (fixed by #9193)