Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enumeration documentation: remove nested class shadowing in "override" position #9419

Merged
merged 1 commit into from Jan 13, 2021
Merged

Enumeration documentation: remove nested class shadowing in "override" position #9419

merged 1 commit into from Jan 13, 2021

Conversation

koterpillar
Copy link
Contributor

Enumeration documentation has an example that is affected by #8705 with the following code:

protected case class Val(mass: Double, radius: Double) extends super.Val

This PR changes the shadowing class name to avoid the ambiguity.

@scala-jenkins scala-jenkins added this to the 2.12.14 milestone Jan 5, 2021
dwijnand
dwijnand approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you.

@dwijnand dwijnand assigned retronym and unassigned retronym Jan 6, 2021
@dwijnand dwijnand merged commit d057f62 into scala:2.12.x Jan 13, 2021
@dwijnand dwijnand added the welcome hello new contributor! label Jan 13, 2021
@SethTisue
Copy link
Member

welcome to the repo!

@SethTisue SethTisue added the documentation No code change. Only documentation label Jan 13, 2021
@koterpillar koterpillar deleted the patch-1 branch January 13, 2021 22:30
@retronym retronym mentioned this pull request Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

@dwijnand dwijnand dwijnand approved these changes

Assignees
No one assigned
Labels
documentation No code change. Only documentation welcome hello new contributor!
Projects
None yet
Milestone
2.12.14
5 participants
@koterpillar @SethTisue @dwijnand @retronym @scala-jenkins