Disallow new MyObj.type
#9457
Merged
Disallow new MyObj.type
#9457
+41
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
Jan 26, 2021
dwijnand
reviewed
Jan 27, 2021
| @@ -4763,7 +4763,7 @@ trait Types | |||
| /** def isNonValueType(tp: Type) = !isValueElseNonValue(tp) */ | |||
|
|
|||
| def isNonRefinementClassType(tpe: Type) = tpe match { | |||
| case SingleType(_, sym) => sym.isModuleOrModuleClass | |||
| case SingleType(_, sym) => sym.isModuleClass | |||
There was a problem hiding this comment.
For the record: this reverts the change here that came from #9279, by moving it locally to typedClassOf.
SethTisue
changed the title
new, but do allow them for classOf
SethTisue
changed the title
new, but do allow them for classOfclassOf[Foo.type]
|
This is just a bug fix. #9279 was the improvement which we shipped and release noted in 2.13.4. |
|
"Just" in the "no need to release note it" sense 🙇🏼 thank you for the fix!! |
|
💔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... while still allowing
classOf[MyObj.type].Fixes scala/bug#12322