Allow renaming imports from _root_ #9482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
requested changes
Feb 3, 2021
There was a problem hiding this comment.
As Jasper mentions this guard exists due to scala/bug#283 in 4e45e9e without a test case. Could you add that test case now so we don't accidentally regress on that, please?
|
@dwijnand Do you mean |
|
I'm not sure if it's just that or that + the use of a static method. So just the test case as it is in the ticket, IMO. |
|
It's charming how back then sometimes they used parens and sometimes not. Fixing a 3-digit ticket is pretty cool, but adding a 3-digit test case is a close second. |
dwijnand
approved these changes
Feb 3, 2021
|
@lrytz final review/merge? |
|
@som-snytt is there anything in the spec about this? |
|
Spec 9.4 doesn't mention the previous limitation. |
lrytz
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
import _root_.{x => y}Fixes scala/bug#9125