Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow $ escaping double quotes in interpolations #9536

Merged
merged 2 commits into from Mar 17, 2021
Merged

allow $ escaping double quotes in interpolations #9536

merged 2 commits into from Mar 17, 2021

Conversation

martijnhoekstra
Copy link
Contributor

@martijnhoekstra martijnhoekstra commented Mar 8, 2021 •
edited by lrytz

@scala-jenkins scala-jenkins added this to the 2.13.6 milestone Mar 8, 2021
@dwijnand
Copy link
Member

dwijnand commented Mar 8, 2021

Gonna merge conflict with #8830.

@dwijnand dwijnand mentioned this pull request Mar 8, 2021
Merged
@martijnhoekstra martijnhoekstra force-pushed the escdollar3 branch 2 times, most recently from 9f07b42 to fedd2c9 Compare March 8, 2021 16:35
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Mar 9, 2021
@lrytz lrytz force-pushed the escdollar3 branch 2 times, most recently from 5ddf824 to 84c7d79 Compare March 17, 2021 13:27
lrytz
lrytz approved these changes Mar 17, 2021
View reviewed changes
Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@lrytz lrytz enabled auto-merge March 17, 2021 13:34
@lrytz lrytz merged commit ac73ea3 into scala:2.13.x Mar 17, 2021
@lrytz lrytz changed the title allow $ escaping double quotes in interpolations under -Xsource:3 allow $ escaping double quotes in interpolations May 17, 2021
julienrf added a commit to scalacenter/docs.scala-lang that referenced this pull request May 3, 2022
@julienrf
Mark SIP 37 as complete
d8e3b68 
Assigned number 37 to SIP “Quote escapes for interpolations”.

Implemented in Scala 2.13.6 in scala/scala#9536
Implemented in Scala 3.0.0 in scala/scala3#7486
julienrf added a commit to scala/improvement-proposals that referenced this pull request Jun 9, 2022
@julienrf
Mark SIP 37 as complete
fbd9d70 
Assigned number 37 to SIP “Quote escapes for interpolations”.

Implemented in Scala 2.13.6 in scala/scala#9536
Implemented in Scala 3.0.0 in scala/scala3#7486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz approved these changes

Assignees
No one assigned
Labels
release-notes worth highlighting in next release notes
Projects
None yet
Milestone
2.13.6
5 participants
@martijnhoekstra @dwijnand @lrytz @SethTisue @scala-jenkins