Deprecate IterableOps.toIterable
#9774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
approved these changes
Sep 29, 2021
SethTisue
added
the
library:collections
|
is this release notes worthy? |
|
probably. I was thinking that if people aren't using it they don't care and if they are using it they'll see the deprecation warning. but on second thought, I think it's better to call attention it |
SethTisue
approved these changes
Sep 30, 2021
SethTisue
changed the title
IterableOps.toIterable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method is a noop on any
Iterable, it only does something for an object that is anIterableOpsbut not anIterable. This should never be the case in user code.The method is cofusing because its name is like
toListortoSeq, buttoIterablereturns non-immutable collections unchanged.toIterableis therefore also different fromto(Iterable).