Fix 2.13.7 releaseFence regression affecting GraalVM compatibility
#9825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Non-specialized val fields in a specialized class are made non-final because of the way specialization is encoded. A `releaseFence` call is added to the constructor to ensure safe publication. The releaseFence call is not necessary for class parameters as those remain final. Follow-up for scala#9704, fixes scala/bug#12500
joroKr21
approved these changes
Dec 10, 2021
SethTisue
changed the title
releaseFence for class params of specialized classesreleaseFence regression affecting GraalVM compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't emit
releaseFencefor class params of specialized classesNon-specialized val fields in a specialized class are made non-final
because of the way specialization is encoded. A
releaseFencecallis added to the constructor to ensure safe publication.
The releaseFence call is not necessary for class parameters as those
remain final.
Follow-up for #9704, fixes scala/bug#12500