Upgrade to Scala 2.13.4, switch CI to JDK 15, tweak CI configuration

[smarter]

2.13.4 brings JDK 15 support with scala/scala#9292

[griggt]

While you're changing the CI configuration, what do you think about adding a JDK 11 bootstrapped test during the nightly run, so that #10319 will actually catch any regressions?

[smarter]

I already regenerated the docker image with JDK 15 and 8 but not 11, so it's a bit late for that (and I'm getting tired of staring at YAML), I'm not too worried about #9200 regressing again so I don't think it's critical to get a JDK 11 build in the CI for now.

[griggt]

Big 👍 on the magic strings in commit messages to tweak the CI run.

[smarter]

Sigh, it looks like github.event.head_commit.message doesn't work on PRs so I might have to abandon the magic string thing, there are workarounds but they look more tedious than what I have the patience for right now: https://github.community/t/please-reconsider-setting-github-commit-message-or-equivalent/17615/5

[griggt]

How about using github.event.pull_request.body or github.event.pull_request.title?

[smarter]

So to turn on/off some checks we'd have to modify the pull request message? That's less convenient than the commit message but I guess we can go with that if there's no alternative.

[smarter]

@sjrd I tried upgrading to JDK 15 / Scala 2.13.4 / Scala.js 1.3.1 but a JUnit Scala.js test fails, any idea what this is?

java.lang.IllegalArgumentException: requirement failed: a member can have a constructor name iff it is in the constructor namespace while compiling /__w/dotty/dotty/tests/sjs-junit/../out/bootstrap/sjsJUnitTests/scala-3.0.0-M2/src_managed/main/BuildInfo.scala, /__w/dotty/dotty/tests/sjs-junit/../out/bootstrap/sjsJUnitTests/scala-js-src-1.3.1/test-suite/js/src/main/scala/org/scalajs/testsuite/jsinterop/NonNativeTypeTestSeparateRun.scala, /__w/dotty/dotty/tests/sjs-junit/../out/bootstrap/sjsJUnitTests/scala-js-src-1.3.1/test-suite/js/src/main/scala/org/scalajs/testsuite/junit/MultiCompilationTest.scala, /__w/dotty/dotty/tests/sjs-junit/../out/bootstrap/sjsJUnitTests/scala-js-src-1.3.1/test-suite/js/src/main/scala/org/scalajs/testsuite/utils/Platform.scala
Error:  ## Exception when compiling 4 sources to /__w/dotty/dotty/tests/sjs-junit/../out/bootstrap/sjsJUnitTests/scala-3.0.0-M2/classes
Error:  java.lang.IllegalArgumentException: requirement failed: a member can have a constructor name iff it is in the constructor namespace
Error:  scala.Predef$.require(Predef.scala:338)
Error:  org.scalajs.ir.Trees$MethodDef.<init>(Trees.scala:1073)
Error:  org.scalajs.ir.Trees$MethodDef$.apply(Trees.scala:1062)
Error:  dotty.tools.backend.sjs.JSCodeGen.genMethodWithCurrentLocalNameScope$$anonfun$1(JSCodeGen.scala:1098)
Error:  dotty.tools.backend.sjs.ScopedVar$.withScopedVars(ScopedVar.scala:35)
Error:  dotty.tools.backend.sjs.JSCodeGen.genMethodWithCurrentLocalNameScope(JSCodeGen.scala:1120)
Error:  dotty.tools.backend.sjs.JSCodeGen.$anonfun$59(JSCodeGen.scala:976)
Error:  scala.collection.immutable.List.flatMap(List.scala:293)
Error:  dotty.tools.backend.sjs.JSCodeGen.genJSClassCapturesAndConstructor$$anonfun$2(JSCodeGen.scala:976)
Error:  dotty.tools.backend.sjs.JSCodeGen.withNewLocalNameScope$$anonfun$1(JSCodeGen.scala:117)
Error:  dotty.tools.backend.sjs.ScopedVar$.withScopedVars(ScopedVar.scala:35)
Error:  dotty.tools.backend.sjs.JSCodeGen.withNewLocalNameScope(JSCodeGen.scala:118)
Error:  dotty.tools.backend.sjs.JSCodeGen.genJSClassCapturesAndConstructor(JSCodeGen.scala:997)
Error:  dotty.tools.backend.sjs.JSCodeGen.genNonNativeJSClass(JSCodeGen.scala:525)
Error:  dotty.tools.backend.sjs.JSCodeGen.genCompilationUnit$$anonfun$6$$anonfun$1(JSCodeGen.scala:211)
Error:  dotty.tools.backend.sjs.ScopedVar$.withScopedVars(ScopedVar.scala:35)
Error:  dotty.tools.backend.sjs.JSCodeGen.genCompilationUnit$$anonfun$2(JSCodeGen.scala:221)
Error:  dotty.runtime.function.JProcedure1.apply(JProcedure1.java:15)
Error:  dotty.runtime.function.JProcedure1.apply(JProcedure1.java:10)
Error:  scala.collection.immutable.List.foreach(List.scala:333)
Error:  dotty.tools.backend.sjs.JSCodeGen.genCompilationUnit(JSCodeGen.scala:223)
Error:  dotty.tools.backend.sjs.JSCodeGen.run(JSCodeGen.scala:152)
Error:  dotty.tools.backend.sjs.GenSJSIR.run(GenSJSIR.scala:15)
Error:  dotty.tools.dotc.core.Phases$Phase.runOn$$anonfun$1(Phases.scala:296)
Error:  scala.collection.immutable.List.map(List.scala:250)
Error:  dotty.tools.dotc.core.Phases$Phase.runOn(Phases.scala:297)
Error:  dotty.tools.dotc.Run.runPhases$4$$anonfun$4(Run.scala:185)
Error:  dotty.runtime.function.JProcedure1.apply(JProcedure1.java:15)
Error:  dotty.runtime.function.JProcedure1.apply(JProcedure1.java:10)
Error:  scala.collection.ArrayOps$.foreach$extension(ArrayOps.scala:1323)
Error:  dotty.tools.dotc.Run.runPhases$5(Run.scala:195)
Error:  dotty.tools.dotc.Run.compileUnits$$anonfun$1(Run.scala:203)
Error:  dotty.runtime.function.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)
Error:  dotty.tools.dotc.util.Stats$.maybeMonitored(Stats.scala:67)
Error:  dotty.tools.dotc.Run.compileUnits(Run.scala:210)
Error:  dotty.tools.dotc.Run.compileSources(Run.scala:147)
Error:  dotty.tools.dotc.Run.compile(Run.scala:129)
Error:  dotty.tools.dotc.Driver.doCompile(Driver.scala:38)
Error:  dotty.tools.dotc.Driver.process(Driver.scala:195)
Error:  dotty.tools.dotc.Main.process(Main.scala)

[griggt]

Yeah, you'd have to edit the pull request message or the pull request title and re-sync. Definitely less convenient but a drop in replacement for what you've already built and it's better than what we have now (nothing).

IIRC scala/scala uses magic strings in PR titles, such as [ci: last-only], maybe using the title is preferable to the body?

[sjrd]

The changes for Scala.js can be found in #10423. You can either merge that one first, or rebase this PR on top of it, or cherry-pick the commit. Whichever works best for you.

[smarter]

IIRC scala/scala uses magic strings in PR titles, such as [ci: last-only], maybe using the title is preferable to the body?

I ended up going with the PR body since that avoids adding noise to the titles when looking at the list of open PRs.

[griggt]

The conditional logic for the community build jobs needs fixing so that publish_sbt_release will work, and there is a check file that should be deleted. Otherwise LGTM.