Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: deinit submodules before running actions/checkout #11877

Closed
wants to merge 6 commits into from

Conversation

smarter
Copy link
Member

@smarter smarter commented Mar 24, 2021

This action runs "git submodule foreach" early which will fail if a
submodule has been deleted but is still present in the repo (see
actions/checkout#354).

@smarter smarter force-pushed the fix-submodules-2 branch 2 times, most recently from 0bbd37c to 0bda3c7 Compare March 24, 2021 12:34
@michelou
Copy link
Collaborator

michelou commented Mar 24, 2021

This action runs "git submodule foreach" early which will fail if a submodule has been deleted but is still present in the repo (see actions/checkout#354).

@smarter I must admit ... I am reassured to see that others sometimes also have problems with submodules 😑

@smarter smarter force-pushed the fix-submodules-2 branch 2 times, most recently from c20d007 to 15f0692 Compare March 24, 2021 12:57
This action runs "git submodule foreach" early which will fail if a
submodule has been deleted but is still present in the repo (see
actions/checkout#354).
@@ -132,6 +138,9 @@ jobs:
)"

steps:
- name: Cleanup submodules
run: git reset --hard HEAD && git submodule sync && git submodule deinit -f . || true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Windows, we need shell: cmd, see the lines below.

@smarter smarter closed this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants