Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember compared polytypes #13663

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Remember compared polytypes #13663

merged 2 commits into from
Oct 4, 2021

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Oct 3, 2021

Remember comparisons of PolyTypes in comparedTypeLambdas. This means that parameters
of such types will not be added to the constraint as parts of bounds. We already do the same for
HkTypeLambdas but for some reason we forgot to do it for PolyTypes, which are the other kind of type
lambdas.

Fixes #13660
Fixes #7888

Allows perspective to be re-enabled in CB

Remember comparisons of PolyTypes in `comparedTypeLambdas`. This means that parameters
of such types will not be added to the constraint. We already do the same for HkTypeLambdas
but for some reason we forgot to do it for PolyTypes, which are the other kind of type lambdas.

Fixes scala#13660

Allows perspective to be re-enabled in CB
@odersky odersky requested a review from smarter October 3, 2021 14:57
@odersky odersky self-assigned this Oct 3, 2021
@odersky
Copy link
Contributor Author

odersky commented Oct 3, 2021

Also:

Fixes #7888

@odersky odersky assigned odersky and smarter and unassigned odersky Oct 3, 2021
@smarter smarter merged commit 9ecacb1 into scala:master Oct 4, 2021
@smarter smarter deleted the fix-13660 branch October 4, 2021 13:57
@Kordyjan Kordyjan added this to the 3.1.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pickling crash compiling perspective from community build assertion failed: orphan parameter reference
3 participants