Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reachability by retaining spaces of Prod params #14118

Merged
merged 1 commit into from
Dec 19, 2021
Merged

Fix reachability by retaining spaces of Prod params #14118

merged 1 commit into from
Dec 19, 2021

Commits on Dec 15, 2021

  1. Fix reachability by retaining spaces of Prod params 

    When intersecting a product type space with a type space, if the two
types aren't related, we must retain the spaces of the parameters,
otherwise the intersection will represent a bigger space of values that
it should (leading to a false positive unreachability warning).

I actually think that the first condition, `isSubType(tp1, tp2)`, should
be true, because `Bar` is a subtype of `Foo[X]`, provided `X` is
instantiated to `Nothing`.  Maybe that's not isSubType but something
else (because we want forSome X, not forAll X).  But, either way, fixing
that the intersection doesn't overpromise (i.e. lie) is a good fix
anyways.
    @dwijnand
    dwijnand committed Dec 15, 2021
    Configuration menu
    Copy the full SHA
    a648468 View commit details
    Browse the repository at this point in the history