Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13.8 (was 2.13.6) #14258

Merged
merged 1 commit into from Jan 21, 2022
Merged

Scala 2.13.8 (was 2.13.6) #14258

merged 1 commit into from Jan 21, 2022

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Jan 12, 2022

Not sure what the policy is — is this eligible for 3.1.1, or does it wait for 3.2?

Also not sure if 2.13.7 was skipped for a reason, or just nobody thought of it. Regardless, I've added opening a PR such as this one to the Scala 2 release steps, for next time.

@SethTisue
Copy link
Member Author

Is the test failure something I should just add a checkfile update for?

@som-snytt
Copy link
Contributor

No, the output is wrong:

Type argument C does not have the same kind as its bound [_$$1]

instead of underscore

-- Error: tests/neg/i8752.scala:3:39 ------------------------------------------------------------------------------------------------------------
3 |trait Arround1[C <:[X]=>>IterableOps[X,C,C[X]] ] // error // error
  |                                       ^
  |                                       Type argument C does not have the same kind as its bound [_]

Vulpix not running in partest --show-diff mode is really too bad, as it's not possible to run diff on CI output.

But it's great that the message uses its and not it's.

@SethTisue
Copy link
Member Author

Is this conceivably related to the Scala 2 version bump?

@som-snytt
Copy link
Contributor

As Wallace Shawn famously says in the movie, "Inconceivable!"

@som-snytt
Copy link
Contributor

No, it wasn't caused by this Scala version bump, because it's already broken by bumping to 2.13.7!

@som-snytt
Copy link
Contributor

som-snytt commented Jan 13, 2022

Eerily, 2.13.7 includes "Fix 2.13.7 regression affecting wildcards and F-bounded types" and happens to break "F-bounds of type parameters may not be type lambdas/Type argument C does not have the same kind as its bound [_]" on the other compiler. This is why the compilers share the least amount of code possible.

@SethTisue
Copy link
Member Author

fyi @lrytz @joroKr21, does this ring any bells?

@som-snytt
Copy link
Contributor

som-snytt commented Jan 17, 2022

It's due to the wildcard in the sig, but I didn't decide if the change is as intended. I saw the discussion with Lukas, which I'll revisit. I guess Scala 3 will also emit funny-looking temp names in messages? so who cares, just update the check file.

@SethTisue
Copy link
Member Author

I saw the discussion with Lukas, which I'll revisit

link?

in the meantime, I've updated the checkfile.

@som-snytt
Copy link
Contributor

After poking around where I don't yet understand, I guessed scala/scala#9806 or scala/scala#9815 changed the signature (of IterableOps?) seen by Scala 3 so it gets _$$1 instead of _. trait IterableOps[+A, +CC[_], +C]. But if it doesn't ring @joroKr21 's bell, probably I am off base.

@joroKr21
Copy link
Member

RefChecks can't change the signature though - it's just checks. Maybe scala/bug#12488 but that applies only to existential types and this is a higher-kinded type right?

@Kordyjan Kordyjan requested a review from smarter January 21, 2022 06:48
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to also keep the stdlib213 submodule up-to-date.

@smarter smarter merged commit 7ce60e1 into scala:master Jan 21, 2022
@SethTisue SethTisue deleted the scala-2.13.8 branch January 21, 2022 21:57
@SethTisue
Copy link
Member Author

SethTisue commented Jan 21, 2022

It'd be nice to also keep the stdlib213 submodule up-to-date

ah, good call, that didn't occur to me.

I've added it to the Scala 2 release steps: scala/scala-dev@1602898

and I've opened #14322

fyi @lrytz

@SethTisue
Copy link
Member Author

Is this being considered for 3.1.x, or will it wait for 3.2?

@smarter
Copy link
Member

smarter commented Mar 12, 2022

This PR is part of 3.1.2-RC1 (you can see the first tag a PR was part of at the top of the page on github).

@SethTisue
Copy link
Member Author

SethTisue commented Mar 12, 2022

duh, sorry. I also should have thought to check this:

Welcome to Scala 3.1.2-RC2 (17.0.2, Java OpenJDK 64-Bit Server VM).
Type in expressions for evaluation. Or try :help.
                                                                                                    
scala> util.Properties.versionString
val res0: String = version 2.13.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants