-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make initialization checker see through synthetic applys #14283
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
28a8761
Treat synthetic apply of case class as new expression
liufengyun 28cb972
Fix outer selection
liufengyun 1790ef1
Fix test: synthetic apply is now transparent
liufengyun e5cd6fa
Lazily use synthetic apply
liufengyun d8fb65a
Fix outer for calling instantiate
liufengyun 01e0b3f
Add assertion to make sure selection makes sense
liufengyun 3b38f12
Use extension method syntax
liufengyun File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
case class A(b: B) | ||
|
||
object A: | ||
def foo(b: B) = new A(b) | ||
inline def bar(b: B) = new A(b) | ||
|
||
class B: | ||
val a = A(this) | ||
val a2 = A.foo(this) // error | ||
val a3 = A.bar(this) | ||
|
||
// test receiver is ThisRef | ||
|
||
object O: | ||
case class A(b: B) | ||
|
||
object A: | ||
def foo(b: B) = new A(b) | ||
inline def bar(b: B) = new A(b) | ||
|
||
class B: | ||
val a = A(this) | ||
val a2 = A.foo(this) // error | ||
val a3 = A.bar(this) | ||
|
||
val b = new B | ||
end O | ||
|
||
|
||
// test receiver is Warm | ||
|
||
class M(n: N): | ||
case class A(b: B) | ||
|
||
object A: | ||
def foo(b: B) = new A(b) | ||
inline def bar(b: B) = new A(b) | ||
|
||
class B: | ||
val a = A(this) | ||
val a2 = A.foo(this) // error | ||
val a3 = A.bar(this) | ||
end M | ||
|
||
class N: | ||
val m = new M(this) | ||
val b = new m.B |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered whether it would make sense to
instantiate
a synthetic apply even iftarget.hasSource
is false. But if we don't have source for the synthetic apply, then we probably also don't have source for the class constructor, soinstantiate
wouldn't be useful.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly.
I found one bug in the code above: the outer for
instantiate
is incorrect. I'll come up with a test to show the bug and fix it in this PR.