Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct highlight interpolation in explain message #14802

Merged
merged 1 commit into from Mar 29, 2022

Commits on Mar 29, 2022

  1. fix: correct highlight interpolation in explain message

    Currently the output of `explain` when you are missing a return type in
    an abstract declaration looks like this:
    
    ```
    scala> trait Foo:
         |   def foo
    -- [E019] Syntax Error: --------------------------------------------------------
    2 |  def foo
      |         ^
      |         Missing return type
      |-----------------------------------------------------------------------------
      | Explanation (enabled by `-explain`)
      |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
      | An abstract declaration must have a return type. For example:
      |
      | trait Shape {hl(
      |   def area: Double // abstract declaration returning a Double
      | )}
       -----------------------------------------------------------------------------
    ```
    
    This fixes the interpolation issue so the return correctly shows:
    
    ```
    scala> trait Foo:
         |   def foo
    -- [E019] Syntax Error: --------------------------------------------------------
    2 |  def foo
      |         ^
      |         Missing return type
      |-----------------------------------------------------------------------------
      | Explanation (enabled by `-explain`)
      |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
      | An abstract declaration must have a return type. For example:
      |
      | trait Shape:
      |   def area: Double // abstract declaration returning a Double
       -----------------------------------------------------------------------------
    ```
    The `def area: Double` is now also correctly colored.
    ckipp01 committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    b8c9d5a View commit details
    Browse the repository at this point in the history