Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly metals backport #19921

Merged
merged 3 commits into from Mar 12, 2024
Merged

Weekly metals backport #19921

merged 3 commits into from Mar 12, 2024

Conversation

kasiaMarek
Copy link
Collaborator

@kasiaMarek kasiaMarek requested a review from tgodzik March 11, 2024 14:04
)

// TODO: Add a separate option for hints for context bounds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that from original PR? We should remove it here and have na issue for it then

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I just copied it. I'm not even sure what it means. @jkciesluk will you create an issue?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've discussed with @rochala if decorations for evidence parameters are useful and we decided to add a separate option for them. The PR is almost ready, I will create an issue for it too.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasiaMarek kasiaMarek merged commit 3694d95 into scala:main Mar 12, 2024
19 checks passed
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants