Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install libxss1 to fix missing libXss.so.1 #19

Merged
merged 3 commits into from Jan 15, 2021
Merged

install libxss1 to fix missing libXss.so.1 #19

merged 3 commits into from Jan 15, 2021

Conversation

philippotto
Copy link
Member

@philippotto philippotto self-assigned this Jan 14, 2021
@daniel-wer
Copy link
Member

In the linked PR, a maintainer mentioned that people should switch to google-chrome-stable and the docs were adapted accordingly. We could also do that to avoid such problems in the future. I'd guess that we don't need libxss1, then.

@philippotto
Copy link
Member Author

Yeah, I read that, too, but the comments didn't really confirm (only suggested) that switching from unstable to stable really fixes this particular issue. But we can certainly try it out. Would be the more stable route in the long-term. I'll open a second PR.

Copy link
Contributor

@jstriebel jstriebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for result from #20, but LGTM 👍

puppeteer/Dockerfile Outdated Show resolved Hide resolved
@philippotto
Copy link
Member Author

There still seems to be an issue (see https://app.circleci.com/pipelines/github/scalableminds/webknossos/2095/workflows/d7696ec9-b772-47f9-913d-91872a55c513/jobs/13296) with the missing libXss.so which is why I'd like to merge this PR, too. I've left chrome at stable for now. If this doesn't work for us (maybe there will be new problems), we can switch to unstable again. Agree?

@jstriebel
Copy link
Contributor

Sure 👍 :shipit:

@philippotto philippotto merged commit 7ea753e into master Jan 15, 2021
@philippotto philippotto deleted the libxss1 branch January 15, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants