Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint and related dependencies #3063

Merged
merged 9 commits into from Aug 16, 2018
Merged

Update eslint and related dependencies #3063

merged 9 commits into from Aug 16, 2018

Conversation

daniel-wer
Copy link
Member

@daniel-wer daniel-wer commented Aug 15, 2018

This PR updates eslint and all related dependencies. See issue #2880 for related discussion. I waited till eslint-config-airbnb officially added support for eslint v5 and another issue in eslint-plugin-react was fixed. There is a remaining issue in babel-eslint (which doesn't look like it's going to be fixed soon, PR has been open for months), for which I've added eslint-ignores with a hint when to remove them.

URL of deployed dev instance (used for testing):

Steps to test:

  • As a lot of setState calls were refactored I'll probably use the manual testing protocol, not sure yet.
  • Thorough review ;)

Issues:


@@ -32,15 +32,19 @@
"Generator": false
},
"rules": {
"quotes": ["error", "double", { "avoidEscape": true }],
"max-len": ["off", 100],
"array-callback-return": "warn",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sorted the rules alphabetically, which is why there are so many changes. I've also added a couple of rules here. Easiest way to check (if you want to) is probably to sort the rules from the old file alphabetically and then do a diff :/

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice diligent work 👍 🎉

@daniel-wer daniel-wer merged commit b6ab3f8 into master Aug 16, 2018
@daniel-wer daniel-wer deleted the update-eslint branch August 16, 2018 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update eslint to v5, and eslint related plugins
2 participants