Add proper output option for the forked Java compiler #1694
+35
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
commented
Feb 23, 2022
| ) ::: moreOptions | ||
| else moreOptions | ||
| if (project.javaVersionAtLeast("17", logger)) | ||
| List( |
There was a problem hiding this comment.
Let's only add the additional options if we are the ones adding java semanticdb plugin. Otherwise if it's done manually then it need to be properly configured by the user
kpodsiad
reviewed
Feb 24, 2022
kpodsiad
approved these changes
Feb 24, 2022
Previously, we only added the output directory for the local Java compiler, which caused compile artifacts to pop up in the source directories. Now, we properly add the output directory option. Fixes scalacenter#1691
tgodzik
force-pushed
the
fix-ouput-forked
branch
from
9116d78 to
184f785
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only added the output directory for the local Java compiler, which caused compile artifacts to pop up in the source directories. Now, we properly add the output directory option.
Fixes #1691
I also removed 2 tests that were commented out for a long while.