Skip to content

chore: clean some of unused warnings #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 22, 2022
Merged

chore: clean some of unused warnings #1719

merged 7 commits into from
Apr 22, 2022
+379 −639

Conversation

kpodsiad
Copy link
Collaborator

No description provided.

Kamil Podsiadlo added 2 commits April 12, 2022 08:34
chore: fix unused warnings in frontend
ae1cad5
chore: fix unused warnings backend

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: 5EF7BA26748D673D
Learn about vigilant mode
9ac13e5
@kpodsiad kpodsiad force-pushed the chore/unused-warnings branch from acc564b to 9ac13e5 Compare April 12, 2022 09:22
Kamil Podsiadlo added 3 commits April 12, 2022 12:30
chore: fix warnings in frontend & backend tests

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
16a808d
chore: remove bunch of other warnings
5b3fc77
chore: remove unused warnings in some modules
eeed275
@kpodsiad kpodsiad changed the title chore: fix unused warnings in frontend chore: clean some of unused warnings Apr 13, 2022
@kpodsiad kpodsiad marked this pull request as ready for review April 13, 2022 06:57
kpodsiad
kpodsiad commented Apr 13, 2022
View reviewed changes
Copy link
Collaborator Author

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disabled scalafix plugin on config, bloopgun and launcher modules, because I didn't want to touch public API of these modules.

@kpodsiad kpodsiad requested a review from tgodzik April 13, 2022 07:00
tgodzik
tgodzik requested changes Apr 14, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Glad to see so much unused code removed.

@kpodsiad kpodsiad requested a review from tgodzik April 21, 2022 11:43
chore: remove unused variable

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4ad5940
@kpodsiad kpodsiad force-pushed the chore/unused-warnings branch from 26f9965 to 4ad5940 Compare April 21, 2022 11:43
tgodzik
tgodzik approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kpodsiad kpodsiad merged commit 2a74360 into scalacenter:main Apr 22, 2022
@kpodsiad kpodsiad deleted the chore/unused-warnings branch April 22, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpodsiad @tgodzik