Use Maven for downloading Gradle test kit #1738
Merged
+5
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthurm1
force-pushed
the
gradle_maven_testkit
branch
from
206fd7b to
334a01f
Compare
|
Spurious |
tgodzik
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, downloading the Gradle test kit for building/testing the Gradle plugin required custom code.
Now the jars are all published here so we can use that instead. It also means the source jars are available which is a boon for debugging.
Caveat - I'm not that familiar with SBT so hopefully these changes don't have any side effects on the rest of the build.