Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump scala-debug-adapter with fixes for Scala 3 #1741

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

tgodzik
Copy link
Contributor

@tgodzik tgodzik commented Jun 23, 2022

The most recent milestone works much better thanks to @adpi2 🎉 !

I plan to release 1.5.1 next, because the clean functionality got fixed.

@tgodzik tgodzik requested a review from adpi2 June 23, 2022 08:27
@adpi2
Copy link
Member

adpi2 commented Jun 23, 2022

I added the scalaVersion field in the DebuggeeRunner, so it needs to be added in the BloopDebuggeeRunner implementation.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mback2k Marc Hörsken
Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good for now. But maybe I should declare scalaVersion as an Option so that we can use the scala-debug-adapter to debug pure Java projects.

@tgodzik
Copy link
Contributor Author

tgodzik commented Jun 27, 2022

That looks good for now. But maybe I should declare scalaVersion as an Option so that we can use the scala-debug-adapter to debug pure Java projects.

That might be a good idea. I also noticed that we might needed to add scalacOptions debugger will not work currently with -Xsource:3 etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants