Correctly pick up test-jar dependency sources #1756
Merged
+39
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
test-jar dependencies not only have a different suffix for regular jars
-tests.jar
, but they also have a different one for test sources :D-test-sources.jar
notice that it'stest
nottests
.They also need to have a different classifier (
test-sources
).refactoring
resolveArtifact
now takessources: Boolean
parameter instead of a widerclassifier: Option[String]
- we only ever use it to download sources, so we can tighten down the method contract.I would also argue that
resolveArtifact
needs to returncase class ResolvedArtifact(af: Artifact, sources: Boolean, file: File)
so that we don't need to do this string manipulation with jar names, but it would involve larger refactoring than what I'm ready to commit to in this PR.