Cache ScalaJS linkers for incremental linking #1761
Merged
+38
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
force-pushed
the
js-incremental-linker
branch
from
09cd90c to
6e4abdc
Compare
Avoid caching fullLinkJS linker to save memory
lolgab
force-pushed
the
js-incremental-linker
branch
from
6e4abdc to
fc37fc5
Compare
lolgab
commented
Jul 15, 2022
| val useClosure = input.isFullLinkJS && input.moduleKind != ModuleKindJS.ESModule | ||
|
|
||
| val config = StandardConfig() | ||
| .withOptimizer(true) |
There was a problem hiding this comment.
.withOptimizer(true) should be used also with fastLinkJS.
There was a problem hiding this comment.
withOptimizer(true) is the default anyway. ;)
sjrd
reviewed
Jul 20, 2022
| @@ -51,6 +53,41 @@ object JsBridge { | |||
| } | |||
| override def trace(t: => Throwable): Unit = logger.trace(t) | |||
| } | |||
| private object ScalaJSLinker { | |||
| private val cache = TrieMap.empty[Path, WeakReference[(JsConfig, Linker)]] | |||
There was a problem hiding this comment.
WeakReferences are not the best choice for memory-sensitive caches. Use a SoftReference instead.
| val useClosure = input.isFullLinkJS && input.moduleKind != ModuleKindJS.ESModule | ||
|
|
||
| val config = StandardConfig() | ||
| .withOptimizer(true) |
There was a problem hiding this comment.
withOptimizer(true) is the default anyway. ;)
Co-authored-by: Sébastien Doeraene <sjrdoeraene@gmail.com>
sjrd
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables Scala.js incremental linking by caching the linker in memory in a concurrent map.
To avoid wasting memory (since bloop has a global instance which is long running), this avoid caching the release linkers. Also it caches one linker per output path. If you change the
JsConfigthe previousLinkerinstance will be garbage collected and a new one will be saved in the map.It uses a
scala.collection.concurrent.TrieMapas a mutable map implementation.It also stores
SoftReferences so if the GC needs memory it can drop a linker to make space for something else.The implementation was adapted from the one existing in the Mill build tool.