fix: limit the amount of logs that launcher keeps in memory #1764
+79
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dos65
force-pushed
the
laucnher_logs_oom
branch
2 times, most recently
from
3089fa4 to
1f68a5c
Compare
tgodzik
reviewed
Jul 22, 2022
| @@ -41,11 +41,8 @@ final class BspBridge( | |||
| bspServerStatus = None | |||
| } | |||
|
|
|||
| case class RunningBspConnection(bsp: BspConnection, out: ByteArrayOutputStream) { | |||
| def logs: List[String] = { | |||
There was a problem hiding this comment.
Actually, where are these logs used? Don't we send them out immediately?
There was a problem hiding this comment.
in BspBridge.waitForOpenBsp
There is some logic over log message -
|
Actually, just realised that the test fail due to the new test: https://github.com/scalacenter/bloop/runs/7469473959?check_suite_focus=true |
I'm noticed that this outputStream might produce an unhandled OOM error when it used from Metals (~80MB in memory). Can be reproduced on long running session with a lot of diagnostics.
|
@dos65 I think this one only needs scalafmt and we should be good to merge! |
|
@tgodzik it's workflow failure. Could you rerun it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm noticed that this outputStream might produce an unhandled OOM error when it used from Metals (~80MB in memory).
Can be reproduced on long running session with a lot of diagnostics.