Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scala android plugin on Gradle #1768

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

Arthurm1
Copy link
Contributor

Currently any Gradle Android projects only get a java section not a scala section in the Bloop json exports because there's no real link between the Android sourcesets and java/scala sourcesets so the ScalaCompile info is just floating about.

This PR assumes that if the project has ScalaCompile applied to it then that info should be exported.

So https://github.com/dsvdsv/scala-android-plugin is now supported. It looks dead as it doesn't support later versions of Gradle or Android, but why not.
I've left the test for it commented out as the GradleRunner seems to apply plugins in a different order than real-life Gradle so the test fails on configuration. Testing this on a local build.gradle file appears to work.

Hopefully this should solve scalameta/metals#4036

@Arthurm1
Copy link
Contributor Author

Spurious test failure bloop.launcher.LatestStableLauncherSpec

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit b5cf7cc into scalacenter:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants