Support scala android plugin on Gradle #1768
Merged
+230
−77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any Gradle Android projects only get a
java
section not ascala
section in the Bloop json exports because there's no real link between the Android sourcesets and java/scala sourcesets so theScalaCompile
info is just floating about.This PR assumes that if the project has
ScalaCompile
applied to it then that info should be exported.So https://github.com/dsvdsv/scala-android-plugin is now supported. It looks dead as it doesn't support later versions of Gradle or Android, but why not.
I've left the test for it commented out as the
GradleRunner
seems to apply plugins in a different order than real-life Gradle so the test fails on configuration. Testing this on a localbuild.gradle
file appears to work.Hopefully this should solve scalameta/metals#4036