Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sbt-librarymanagement to 1.1.5 due to CVEs in its 1.0.x tree. #1770

Merged

Conversation

ScalaWilliam
Copy link
Contributor

@ScalaWilliam ScalaWilliam commented Jul 31, 2022

Thank you so much for your help with #1766 - the plug-in is now usable in enterprise!

However one of the dependencies did not pass the screening for CVEs - under bloop-backend there is sbt-librarymanagement 1.0.0 (see here for CVE info -- https://mvnrepository.com/artifact/org.scala-sbt/librarymanagement-core_2.12/1.0.0 ). For an upgrade path, I checked 1.0.4 which is the highest in 1.0.x, but its dependency on jsch still has a CVE, so the next one up without dependent CVEs would be a 1.1.x series, of which 1.1.5 is the highest. The latest available overall is 1.7.0 but I imagine depending on that could potentially cause some breakages if e.g. we're using Bloop from SBT 1.4.x and using a librarymanagement from 1.7.x.

image

I was also wondering if the dep should aso be set as % "provided" as I'd expect it to be provided by SBT anyway.

Copy link
Collaborator

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems reasonable to stick with the lowest minor version possible, which doesn't have CVE 👍

@tgodzik tgodzik merged commit 117b7e0 into scalacenter:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants