Truncate file timestamp in AttributedPath to milliseconds
#1776
Conversation
oyvindberg
commented
Aug 16, 2022
oyvindberg
commented
- this makes it consistent between old and new JVMs, and makes a bunch of tests happy which among other things diff file timestamps
|
Haha, I thought I was going crazy :D https://github.com/scalacenter/bloop/pull/1749/files#r912112085 |
I guess everybody meets this error for the first time, it's certainly very confusing! |
- this makes it consistent between old and new JVMs, and makes a bunch of tests happy which among other things diff file timestamps
oyvindberg
force-pushed
the
truncate-file-timestamp
branch
from
83fabd0 to
e443755
Compare
| @@ -80,7 +82,24 @@ object Paths { | |||
| out.toList | |||
| } | |||
|
|
|||
| case class AttributedPath(path: AbsolutePath, lastModifiedTime: FileTime, size: Long) | |||
| // sealed abstract is an abomination for scala 2.12 to get private which actually works | |||
| sealed abstract case class AttributedPath( | |||
There was a problem hiding this comment.
Why change it to an abstract class?
There was a problem hiding this comment.
What the comment says really. To force all usage to go through the of constructor method.
Older scala versions and private case class constructors is a surprisingly complex topic. For instance this article touches on it https://tuleism.github.io/blog/2020/scala-smart-constructors/
That said, now that the compiler showed me all usage i can change it back to something more normal if this is too weird. I just like having the guarantee
There was a problem hiding this comment.
Ach, sorry! I saw that previously when checking and then forgot 😓
