Run source generators in topological order #1819
Merged
+76
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `buildTarget/sources` BSP request could fail in cases where the build included source generators that depend on the output of other source generators. This issue would happen because, in this case, the ordering in which the source generators would run wasn't clearly defined. During a compilation task, this problem would not appear because the source generators would always be run after their dependencies have run. To fix this problem in the BSP services, Bloop will now run the source generators in the topological order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
buildTarget/sourcesBSP request could fail in cases where the build included source generators that depend on the output of other source generators. This issue would happen because, in this case, the ordering in which the source generators would run wasn't clearly defined.During a compilation task, this problem would not appear because the source generators would always be run after their dependencies have run.
To fix this problem in the BSP services, Bloop will now run the source generators in the topological order.