Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set canDebug capabilities to true #1820

Merged
merged 2 commits into from
Oct 2, 2022
Merged

chore: set canDebug capabilities to true #1820

merged 2 commits into from
Oct 2, 2022
+37 −6

Conversation

kpodsiad
Copy link
Collaborator

@kpodsiad kpodsiad commented Sep 26, 2022 •
edited
Loading

need to fix tests :(

@kpodsiad
chore: set canDebug capabilities to true

Verified

This commit was signed with the committer’s verified signature. The key has expired.
mback2k Marc Hörsken
GPG key ID: 61E03CBED7BC859E
Expired
Verified
Learn about vigilant mode
2baa8dd
@kpodsiad kpodsiad requested a review from tgodzik September 26, 2022 18:10
@kpodsiad kpodsiad mentioned this pull request Sep 26, 2022
Open
@kpodsiad kpodsiad marked this pull request as draft September 26, 2022 19:38
tgodzik
tgodzik requested changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this!

Looks like a bunch of tests failed, most likely they didn't have canDebug in expected.

@kpodsiad kpodsiad marked this pull request as ready for review September 30, 2022 19:23
@kpodsiad
Copy link
Collaborator Author

contains #1781

@kpodsiad kpodsiad requested a review from tgodzik September 30, 2022 19:24
tgodzik
tgodzik approved these changes Oct 2, 2022
View reviewed changes
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🎉

@tgodzik tgodzik merged commit 72f9449 into scalacenter:main Oct 2, 2022
This was referenced Dec 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kpodsiad @tgodzik