bugfix: Try to download semanticdb even if it might not be supported #1821
Conversation
Previously, we would not download semanticdb even if it was backpublished. Now, we will try to download, but not print any warning if it's unsupported.
| val isSupportedVersion = | ||
| scalaSemanticdbSettings.supportedScalaVersions.exists(scalaVersion.startsWith(_)) |
There was a problem hiding this comment.
How bloop knows which scala version supports semanticDB and which doesn't?
There was a problem hiding this comment.
Metals sends that information, but since we backpublish Metals no longer has that information.
| // We try to download anyway, but don't print the exception | ||
| case _ => |
There was a problem hiding this comment.
Can you explain what will happen if downloading semanticDB fails? Is this possible that user won't have code navigation and no indication why?
Also, I think comment might have better description, as this action (downloading) already took place and we handling failed case. For instance:
// We tried to download semanticDB but scala version is unsupported - don't warn the user about it.
case Left(cause) =>
logger.debug(cause) (or sth along these lines?)
NoneThere was a problem hiding this comment.
Can you explain what will happen if downloading semanticDB fails? Is this possible that user won't have code navigation and no indication why?
No, they will always get the information that semanticdb options are missing. I decided not to show it to the user as a notification if the version is not expected to be supported. I could change that, but this should ideally not happen.
There was a problem hiding this comment.
I will update it when doing another change.
Previously, we would not download semanticdb even if it was backpublished. Now, we will try to download, but not print any warning if it's unsupported.