Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support traversal mode in Dag.dfs #1838

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

Duhemm
Copy link
Collaborator

@Duhemm Duhemm commented Oct 16, 2022

Previously, Dag.dfs would always do pre-order traversal. This commit adds a mode parameter which allows to select pre-order or post-order traversal. Also, this commit replaces calls to Dag.topologicalSort with Dag.dfs with mode = PostOrder.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Previously, `Dag.dfs` would always do pre-order traversal. This commit
adds a `mode` parameter which allows to select pre-order or post-order
traversal. Also, this commit replaces calls to `Dag.topologicalSort`
with `Dag.dfs` with `mode = PostOrder`.
Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodzik tgodzik merged commit 0007460 into scalacenter:main Oct 17, 2022
@Duhemm Duhemm deleted the dag-topological-sort-perf branch October 18, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants