Use scala-debug-adapter 3.0 #1841
Merged
+163
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests do not pass because the new step filter does not like when a class is defined in the |
adpi2
force-pushed
the
scala-debug-adapter-3
branch
from
82e4648 to
f67c3e4
Compare
|
Ready to be reviewed. There is one test that failed but it seems totally unrelated. |
tgodzik
requested changes
Oct 21, 2022
| getOrTryUpdate(stepFilterCache, scalaVersion) { | ||
| val stepFilterModule = s"${BuildInfo.scala3StepFilterName}_${scalaVersion.binaryVersion}" | ||
| val stepFilter = Artifact(BuildInfo.organization, stepFilterModule, BuildInfo.version) | ||
| val tastyCore = Artifact("org.scala-lang", "tasty-core_3", scalaVersion.value) |
There was a problem hiding this comment.
Why do we need scala 3 artifacts on the classpath. Do we need it even with Scala 2?
There was a problem hiding this comment.
We only need to load the step filter for Scala 3.
The Scala 2 step filter is a direct dependency of the scala-debug-adapter so it does not need to be class loaded in its own class loader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new major version of the scala-debug-adapter brings a number of new features including:
To learn more about those new features you can refer to the release notes